kenton/revert-enumerable-change - Branch - cloudflare/workerd

Revert #5608 but keep the tests.

#5647Merged

Comparing

kenton/revert-enumerable-change

(

ded5e6f

) with

main

(

a4943be

)

Untouched: 57

Skipped: 30

No successful run was found on main ( c708895) during the generation of this report, so a4943be was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

Benchmarks

Skipped (30)

Passed

EncodeInto_TwoByte_1024[TextEncoder][1/2/1024]

src/workerd/tests/bench-text-encoder.c++

14.2 ms14.1 ms

Encode_ASCII_8192[TextEncoder][0/0/8192]

src/workerd/tests/bench-text-encoder.c++

13.1 ms13.1 ms

Serialize

src/workerd/tests/bench-mimetype.c++::Mimetype

74.6 ms74.6 ms

Encode_TwoByte_1024[TextEncoder][0/2/1024]

src/workerd/tests/bench-text-encoder.c++

19.5 ms19.5 ms

Encode_ASCII_256[TextEncoder][0/0/256]

src/workerd/tests/bench-text-encoder.c++

3.1 ms3.1 ms

request[RegExpBenchmark]

src/workerd/tests/bench-regex.c++

7.3 ms7.3 ms

EncodeInto_ASCII_256[TextEncoder][1/0/256]

src/workerd/tests/bench-text-encoder.c++

2.5 ms2.5 ms

Encode_TwoByte_256[TextEncoder][0/2/256]

src/workerd/tests/bench-text-encoder.c++

7 ms7 ms

EncodeInto_OneByte_1024[TextEncoder][1/1/1024]

src/workerd/tests/bench-text-encoder.c++

10.5 ms10.5 ms

JsString_Utf8Length_Latin1_NonFlat_256

src/workerd/tests/bench-jsstring.c++

8 µs8 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_256

src/workerd/tests/bench-jsstring.c++

9 µs9 µs

JsString_Utf8Length_Utf16_NonFlat_256

src/workerd/tests/bench-jsstring.c++

9 µs9 µs

EncodeInto_ASCII_1024[TextEncoder][1/0/1024]

src/workerd/tests/bench-text-encoder.c++

2.6 ms2.6 ms

JsString_Utf8Length_Latin1_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

12.3 µs12.3 µs

JsString_Utf8Length_Utf16_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

16.2 µs16.2 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_1024

src/workerd/tests/bench-jsstring.c++

16.3 µs16.3 µs

Encode_OneByte_1024[TextEncoder][0/1/1024]

src/workerd/tests/bench-text-encoder.c++

12 ms12 ms

JsString_Utf8Length_Latin1_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

42.1 µs42.1 µs

JsString_Utf8Length_Utf16_Invalid_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

73.9 µs73.9 µs

JsString_Utf8Length_Utf16_NonFlat_8192

src/workerd/tests/bench-jsstring.c++

73.9 µs73.9 µs

constructor[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

67.6 ms67.6 ms

JsString_Utf8Length_Utf16_Invalid_Flat_1024

src/workerd/tests/bench-jsstring.c++

8.5 µs8.5 µs

JsString_Utf8Length_Utf16_Invalid_Flat_256

src/workerd/tests/bench-jsstring.c++

2.7 µs2.7 µs

bm_ReadyNow

external/capnp-cpp/src/kj/async-bench.c++

2.1 µs2.1 µs

JsString_Utf8Length_Utf16_Invalid_Flat_8192

src/workerd/tests/bench-jsstring.c++

62.8 µs62.8 µs

bm_coroCoReturn

external/capnp-cpp/src/kj/async-bench.c++

4.6 µs4.6 µs

bm_Immediate

external/capnp-cpp/src/kj/async-bench.c++

3.6 µs3.6 µs

bm_coroCoAwaitImmediate

external/capnp-cpp/src/kj/async-bench.c++

6.2 µs6.2 µs

Parse[KjHeaders]

src/workerd/tests/bench-kj-headers.c++

44.5 µs44.5 µs

JsString_Utf8Length_Latin1_Flat_256

src/workerd/tests/bench-jsstring.c++

1.7 µs1.7 µs

bodyWithHeaders[Response]

src/workerd/tests/bench-response.c++

24.4 µs24.4 µs

JsString_Utf8Length_Latin1_Flat_32

src/workerd/tests/bench-jsstring.c++

891.1 ns891.1 ns

JsString_Utf8Length_Latin1_Flat_8192

src/workerd/tests/bench-jsstring.c++

31 µs31 µs

JsString_Utf8Length_Latin1_Flat_1024

src/workerd/tests/bench-jsstring.c++

4.6 µs4.6 µs

arrayBufferBody[Response]

src/workerd/tests/bench-response.c++

17.5 µs17.5 µs

JsString_Utf8Length_Utf16_Flat_1024

src/workerd/tests/bench-jsstring.c++

8.5 µs8.5 µs

nullBodyWithStatus[Response]

src/workerd/tests/bench-response.c++

10.3 µs10.3 µs

JsString_Utf8Length_Utf16_Flat_256

src/workerd/tests/bench-jsstring.c++

2.7 µs2.7 µs

jsonResponse[Response]

src/workerd/tests/bench-response.c++

35 µs35 µs

JsString_Utf8Length_Utf16_Flat_8192

src/workerd/tests/bench-jsstring.c++

62.8 µs62.8 µs

Util_RecursivelyFreeze

src/workerd/tests/bench-util.c++

10.8 ms10.8 ms

simpleStringBody[Response]

src/workerd/tests/bench-response.c++

20 µs20 µs

EncodeInto_OneByte_8192[TextEncoder][1/1/8192]

src/workerd/tests/bench-text-encoder.c++

66.9 ms66.9 ms

EncodeInto_TwoByte_256[TextEncoder][1/2/256]

src/workerd/tests/bench-text-encoder.c++

5.4 ms5.4 ms

Encode_TwoByte_8192[TextEncoder][0/2/8192]

src/workerd/tests/bench-text-encoder.c++

146.2 ms146.2 ms

Test_JSON_ENC

src/workerd/tests/bench-json.c++

205.5 ms205.5 ms

Encode_OneByte_8192[TextEncoder][0/1/8192]

src/workerd/tests/bench-text-encoder.c++

85.1 ms85.1 ms

EncodeInto_TwoByte_8192[TextEncoder][1/2/8192]

src/workerd/tests/bench-text-encoder.c++

96.7 ms96.7 ms

EncodeInto_OneByte_256[TextEncoder][1/1/256]

src/workerd/tests/bench-text-encoder.c++

4.5 ms4.5 ms

ParseAndSerialize

src/workerd/tests/bench-mimetype.c++::Mimetype

74.9 ms74.9 ms

Test_JSON_DEC

src/workerd/tests/bench-json.c++

3.2 s3.2 s

Encode_ASCII_32[TextEncoder][0/0/32]

src/workerd/tests/bench-text-encoder.c++

3 ms3 ms

request[GlobalScopeBenchmark]

src/workerd/tests/bench-global-scope.c++

53 ms53 ms

set_append[ApiHeaders]

src/workerd/tests/bench-api-headers.c++

11.9 ms11.9 ms

EncodeInto_ASCII_8192[TextEncoder][1/0/8192]

src/workerd/tests/bench-text-encoder.c++

3.3 ms3.3 ms

Encode_OneByte_256[TextEncoder][0/1/256]

src/workerd/tests/bench-text-encoder.c++

5.2 ms5.2 ms

Encode_ASCII_1024[TextEncoder][0/0/1024]

src/workerd/tests/bench-text-encoder.c++

3.7 ms3.7 ms

Commits

Click on a commit to change the comparison range

Base

main

a4943be

-0.01%

Revert #5608 but keep the tests. This reverts the changes to worker.ts in ef0743c563d2690a4ea40a2b05565fe2fed53171 -- but not the tests. The tests pass without the change, demonstrating that the change did not actually do anything. These properties were already enumerable.

ded5e6f

18 hours ago

by kentonv

Home Terms Privacy Docs