Avatar for the salsa-rs user
salsa-rs
salsa
BlogDocsChangelog

fix: accumulated values lost when reused tracked fn skips re-execution

#1099Merged
Comparing
SAY-5:fix-accumulator-wrongresult-issue-923
(
b928af4
) with
master
(
e4ae47b
)
CodSpeed Performance Gauge
+6%
Improvement
1
Untouched
25

Benchmarks

26 total
amortized[InternedInput]
benches/compare.rs::benches::inputs::Mutating Inputs
CodSpeed Performance Gauge
+6%
2.1 µs2 µs
amortized[Input]
benches/compare.rs::benches::inputs::Mutating Inputs
CodSpeed Performance Gauge
+4%
2.1 µs2 µs
new[InternedInput]
benches/compare.rs::benches::inputs::Mutating Inputs
CodSpeed Performance Gauge
+3%
4.7 µs4.6 µs
new[Input]
benches/compare.rs::benches::inputs::Mutating Inputs
CodSpeed Performance Gauge
+2%
9.8 µs9.6 µs
new[SupertypeInput]
benches/compare.rs::benches::inputs::Mutating Inputs
CodSpeed Performance Gauge
+1%
16 µs15.8 µs
mutating[30]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs
CodSpeed Performance Gauge
+1%
14.8 µs14.6 µs
mutating[20]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs
CodSpeed Performance Gauge
+1%
14.5 µs14.4 µs
mutating[10]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs
CodSpeed Performance Gauge
+1%
14.7 µs14.5 µs
accumulator
benches/accumulator.rs::benches::accumulator
CodSpeed Performance Gauge
0%
3.2 ms3.2 ms
new[Input]
benches/compare.rs::benches::inputs::Mutating Inputs
CodSpeed Performance Gauge
0%
97 B97 B
new[InternedInput]
benches/compare.rs::benches::inputs::Mutating Inputs
CodSpeed Performance Gauge
0%
13 B13 B
new[SupertypeInput]
benches/compare.rs::benches::inputs::Mutating Inputs
CodSpeed Performance Gauge
0%
165 B165 B
converge_diverge_nested
benches/dataflow.rs::benches::nested
CodSpeed Performance Gauge
0%
12.7 KB12.7 KB
accumulator
benches/accumulator.rs::benches::accumulator
CodSpeed Performance Gauge
0%
658.4 KB658.4 KB
mutating[10]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs
CodSpeed Performance Gauge
0%
710 B710 B
mutating[30]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs
CodSpeed Performance Gauge
0%
970 B970 B
mutating[20]
benches/compare.rs::benches::mutating_inputs::Mutating Inputs
CodSpeed Performance Gauge
0%
840 B840 B
converge_diverge
benches/dataflow.rs::benches::dataflow
CodSpeed Performance Gauge
0%
9.8 KB9.8 KB
converge_diverge
benches/dataflow.rs::benches::dataflow
CodSpeed Performance Gauge
-1%
167 µs167.9 µs
converge_diverge_nested
benches/dataflow.rs::benches::nested
CodSpeed Performance Gauge
-1%
130.5 µs131.4 µs
amortized[SupertypeInput]
benches/compare.rs::benches::inputs::Mutating Inputs
CodSpeed Performance Gauge
-1%
2.7 µs2.8 µs
many_tracked_structs
benches/incremental.rs::benches::many_tracked_structs
CodSpeed Performance Gauge
-2%
8.3 µs8.5 µs
many_tracked_structs
benches/incremental.rs::benches::many_tracked_structs
CodSpeed Performance Gauge
N/A
0 B0 B
amortized[Input]
benches/compare.rs::benches::inputs::Mutating Inputs
CodSpeed Performance Gauge
N/A
0 B0 B
amortized[SupertypeInput]
benches/compare.rs::benches::inputs::Mutating Inputs
CodSpeed Performance Gauge
N/A
0 B0 B

Commits

Click on a commit to change the comparison range
Base
master
e4ae47b
+10.65%
fix accumulator wrongly skipped when tracked fn reused without re-execute
16ab655
9 days ago
by SAY-5
-4.83%
address review: destructure deep_verify directly to drop unreachable
b928af4
1 day ago
by SAY-5
© 2026 CodSpeed Technology
Home Terms Privacy Docs