devbird/async-to-generator-transform - Branch - swc-project/swc

feat(es2017): Migrate async/await to generator transform to hook-based architecture

#11350Closed

Comparing

devbird/async-to-generator-transform

(

74d487e

) with

dev/single-pass

(

9886761

)

Untouched: 138

Ignored: 1

Benchmarks

Passed

es/preset-env/usage/builtin_type

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

+2%

241 µs236.7 µs

es/preset-env/usage/property

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

+1%

111.8 µs110.3 µs

es/minifier/libs/d3

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

+1%

396.8 ms394.8 ms

es/lints/libs/vue

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

8.3 ms8.3 ms

es/minifier/libs/terser

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

351.3 ms350.3 ms

es/minifier/libs/echarts

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.5 s1.5 s

es/minifier/libs/victory

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

851.4 ms850 ms

es/minifier/libs/react

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

19.6 ms19.5 ms

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

37.1 ms37 ms

es/codegen/colors

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

68.4 µs68.4 µs

es/parser/jquery mobile

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

21.2 ms21.2 ms

es/lints/libs/victory

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

70.8 ms70.7 ms

es/codegen/with-parser/colors

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

155.6 µs155.5 µs

stackoverflow

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

35.8 ms35.8 ms

es/lexer/three

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

17.4 ms17.4 ms

es/minifier/libs/three

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

644.2 ms643.9 ms

es2015_parameters

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

335.3 µs335.2 µs

es/codegen/large

crates/swc_ecma_codegen/benches/bench.rs::benches::bench_cases

640 µs639.8 µs

css/visitor/compare/clone

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

4.8 ms4.8 ms

es/lints/libs/typescript

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

276.4 ms276.3 ms

es/parser/colors

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

79.9 µs79.9 µs

html/document_fragment/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

typescript/fast-strip

crates/swc_ts_fast_strip/benches/assets.rs::benches::fast_ts

418.2 µs418.1 µs

es2015_fn_name

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

282.4 µs282.3 µs

es/parser/backbone

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.6 ms2.6 ms

github

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

42 ms42 ms

es/parser/typescript

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

368.5 ms368.4 ms

html/document_fragment/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

html/document/visitor/compare/visit_mut_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

es/resolver/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

243.4 ms243.4 ms

es/parser/three

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

65.7 ms65.7 ms

es/parser/jquery

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

13.7 ms13.7 ms

es/minifier/libs/typescript

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

3.8 s3.8 s

css/visitor/compare/fold_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.8 ms5.8 ms

es/fixer/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

201.8 ms201.8 ms

css/parser/bootstrap_5_1_3

crates/swc_css_parser/benches/parser.rs::benches::bench_files

46.9 ms46.8 ms

es/lints/libs/echarts

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

114.3 ms114.3 ms

html/document/visitor/compare/fold_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/codegen/with-parser/large

crates/swc_ecma_codegen/benches/with_parse.rs::benches::bench_cases

1.1 ms1.1 ms

css_spec

crates/swc_html_minifier/benches/full.rs::files_document::bench_files_document::html/minify/document

195.4 ms195.4 ms

es/lexer/backbone

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

804 µs803.9 µs

html/parser/parser_document_fragment/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.2 ms22.2 ms

es/lints/libs/lodash

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.2 ms6.2 ms

html/parser/parser_document/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.1 ms22.1 ms

es/lexer/yui

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

3.6 ms3.6 ms

es/lexer/mootools

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

3.3 ms3.3 ms

es/visitor/compare/visit_mut_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

css/lexer/tailwind_3_1_1

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

1.8 ms1.8 ms

es2015_arrow

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

301 µs301 µs

html/document_fragment/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es/parser/mootools

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

10.7 ms10.7 ms

es/visitor/compare/fold_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

es/lexer/cal-com

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

12.6 ms12.6 ms

es2015_instanceof

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

279.6 µs279.6 µs

html/document_fragment/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

html/lexer/css_2021_spec

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

38.7 ms38.7 ms

css/visitor/compare/fold_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.8 ms5.8 ms

html/lexer/github_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14 ms14 ms

es/visitor/compare/clone

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

5.5 ms5.5 ms

html/parser/parser_document/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

71 ms71 ms

html/lexer/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/lexer.rs::benches::bench_files

14 ms14 ms

html/document/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

css/parser/tailwind_3_1_1

crates/swc_css_parser/benches/parser.rs::benches::bench_files

7.2 ms7.2 ms

es/lexer/jquery mobile

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

6.6 ms6.6 ms

babelify-only

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

2.1 ms2.1 ms

parse_and_babelify_jquery

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

98.9 ms98.9 ms

parse_and_babelify_angular

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

159.4 ms159.4 ms

parse_and_babelify_backbone

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

15.3 ms15.3 ms

es/lexer/angular

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

5.8 ms5.8 ms

parse_and_babelify_mootools

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

72.3 ms72.3 ms

es/parser/underscore

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

2.3 ms2.3 ms

css/lexer/bootstrap_5_1_3

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

11.3 ms11.3 ms

css/visitor/compare/visit_mut_span_panic

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

parse_and_babelify_jquery_mobile

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

169.2 ms169.2 ms

es/minifier/libs/lodash

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

113.8 ms113.8 ms

es/visitor/compare/fold_span

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6.8 ms6.8 ms

github

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

41.3 ms41.3 ms

es/lints/libs/moment

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

4.2 ms4.2 ms

parse_and_babelify_yui

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

67.1 ms67.1 ms

es/visitor/compare/visit_mut_span_panic

crates/swc_ecma_parser/benches/compare.rs::benches::bench_cases

6 ms6 ms

es/resolver_with_hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

746.9 ms747 ms

html/document_fragment/visitor/compare/visit_mut_span

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.1 ms1.1 ms

parse_and_babelify_underscore

crates/swc_estree_compat/benches/babelify.rs::benches::bench_cases

13 ms13 ms

css/lexer/foundation_6_7_4

crates/swc_css_parser/benches/lexer.rs::benches::bench_files

9.2 ms9.3 ms

css/parser/foundation_6_7_4

crates/swc_css_parser/benches/parser.rs::benches::bench_files

37.2 ms37.2 ms

es/lexer/jquery

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

4.3 ms4.3 ms

es2022_class_properties

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

385.7 µs385.7 µs

es2018_object_rest_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

291.7 µs291.7 µs

es/hygiene/typescript

crates/swc_ecma_transforms_base/benches/base.rs::benches::bench_cases

422.5 ms422.6 ms

css/visitor/compare/visit_mut_span

crates/swc_css_parser/benches/compare.rs::benches::bench_cases

5.1 ms5.1 ms

es/lexer/underscore

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

683.1 µs683.2 µs

es2015_typeof_symbol

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

276.5 µs276.5 µs

es2020_optional_chaining

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

337.9 µs337.9 µs

es2015_block_scoped_fn

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

291.9 µs292 µs

es/minifier/libs/moment

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

62.6 ms62.6 ms

html/document/visitor/compare/clone

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1 ms1 ms

es2015_duplicate_keys

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

280.3 µs280.4 µs

es/parser/angular

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

16.8 ms16.8 ms

html/document/visitor/compare/fold_span_panic

crates/swc_html_parser/benches/compare.rs::benches::bench_cases

1.2 ms1.2 ms

es2020_nullish_coalescing

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

310.7 µs310.8 µs

es2015_spread

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.3 µs274.4 µs

es/lints/libs/react

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

1.3 ms1.3 ms

es/lints/libs/jquery

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

6.5 ms6.5 ms

es2015_sticky_regex

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

276.4 µs276.5 µs

html/parser/parser_document/stackoverflow_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.2 ms22.2 ms

es/transform/baseline/common_typescript

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

371.1 µs371.3 µs

es/transform/baseline/base

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

259.9 µs260 µs

es2015_shorthand_property

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.2 µs274.3 µs

es2017_async_to_generator

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

274.6 µs274.8 µs

html/parser/parser_document_fragment/github_com_17_05_2022

crates/swc_html_parser/benches/parser.rs::benches::bench_files

22.1 ms22.1 ms

es/target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

276.6 µs276.7 µs

es/parser/yui

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

10.5 ms10.5 ms

es2015_block_scoping

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

456.4 µs456.7 µs

es/lints/libs/antd

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

156.3 ms156.4 ms

es/minifier/libs/jquery

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

96.6 ms96.7 ms

es2015_classes

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

390.7 µs390.9 µs

es2015_destructuring

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

347 µs347.2 µs

es2015_for_of

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

293.6 µs293.8 µs

es2015_computed_props

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

273.9 µs274.1 µs

es/lexer/typescript

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

103.2 ms103.3 ms

es/target/es3

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

398.9 µs399.3 µs

es/parser/cal-com

crates/swc_ecma_parser/benches/parser.rs::benches::bench_files

55.8 ms55.9 ms

html/parser/parser_document_fragment/css_2021_spec

crates/swc_html_parser/benches/parser.rs::benches::bench_files

70.6 ms70.6 ms

es/transform/baseline/common_reserved_word

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::baseline_group

278.3 µs278.6 µs

es/minifier/libs/antd

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

1.9 s1.9 s

es/lexer/colors

crates/swc_ecma_parser/benches/lexer.rs::benches::bench_files

24.7 µs24.7 µs

css_spec

crates/swc_html_minifier/benches/full.rs::files_document_fragment::bench_files_document_fragment::html/minify/document_fragment

195.2 ms195.4 ms

es/target/es2015

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

1.2 ms1.2 ms

es/minifier/libs/vue

crates/swc_ecma_minifier/benches/full.rs::bench_all::bench_libs::es/minifier/libs

142.8 ms143 ms

es/target/es2020

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

470.9 µs473 µs

es/lints/libs/three

crates/swc_ecma_lints/benches/all.rs::files::bench_files::es/lints/libs

50.1 ms50.3 ms

es/target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

-1%

322.4 µs324.7 µs

es2019_optional_catch_binding

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

-1%

282.1 µs284.3 µs

es2016_exponentiation

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::single_tr_group

-1%

289.2 µs291.5 µs

es/target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::version_group

-1%

290.3 µs292.6 µs

es/full-target/es2017

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

-1%

568.9 µs574.8 µs

es/full-target/es2018

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

-1%

550.9 µs556.9 µs

es/full-target/es2016

crates/swc_ecma_transforms_typescript/benches/compat.rs::benches::full_group

-1%

597.5 µs605.3 µs

Ignored

es/preset-env/entry/import

crates/swc_ecma_preset_env/benches/polyfills.rs::benches::bench_cases

Ignored

28.9 µs28.8 µs

Commits

Click on a commit to change the comparison range

Base

dev/single-pass

9886761

-0.03%

feat(es2017): Migrate async/await to generator transform to hook-based architecture ## Summary Implement async/await to generator transformation in the new hook-based transformer architecture, migrating from the legacy `swc_ecma_compat_es2017` crate. ## Changes ### New Implementation - Add `crates/swc_ecma_transformer/src/es2017/async_to_generator.rs` - Implements `VisitMutHook<TraverseCtx>` trait for hook-based traversal - Transforms async functions to generator functions wrapped with helper - Transforms await expressions to yield expressions - Handles for-await-of loops with proper iterator protocol - Supports async arrow functions and async methods - Handles `this`, `arguments`, and `super` references correctly ### ES2017 Module Integration - Update `crates/swc_ecma_transformer/src/es2017/mod.rs` - Wire up `async_to_generator` hook to `Es2017Pass` - Add `Config` option to enable/disable the transform - Delegate all relevant hook methods to the transform ### Hook Utilities - Update `crates/swc_ecma_transformer/src/hook_utils.rs` - Add missing hook methods to `OptionalHook`: - `enter/exit_function`, `enter/exit_arrow_expr` - `enter/exit_class`, `enter/exit_constructor` - `enter/exit_getter_prop`, `enter/exit_setter_prop` - `enter/exit_super` ### Transformer Module - Update `crates/swc_ecma_transformer/src/lib.rs` - Make `es2017` module public for external access ### Preset Environment Integration - Update `crates/swc_ecma_preset_env/src/lib.rs` - Replace legacy `es2017::async_to_generator` with new hook-based version - Set `options.env.es2017.async_to_generator` when feature not supported - Pass `unresolved_ctxt` to the transform config ## Technical Details ### Transform Rules The implementation follows the Babel spec for async/await transformation: ```javascript // Input async function foo() { const result = await bar(); return result; } // Output function foo() { return _asyncToGenerator(function* () { const result = yield bar(); return result; }).apply(this, arguments); } ``` Key behaviors: - Convert async functions to generator functions wrapped with `_asyncToGenerator` helper - Transform await expressions to yield expressions - Preserve `this`, `arguments`, and `super` bindings - Handle function parameter evaluation errors - Transform for-await-of loops to try-catch-finally with iterator protocol ### Compatibility - Legacy `swc_ecma_compat_es2017` crate unchanged for backward compatibility - New implementation used by `swc_ecma_preset_env` for single-pass compilation - Config stores `unresolved_ctxt` for proper scope handling ## References - Babel plugin: https://github.com/babel/babel/tree/main/packages/babel-plugin-transform-async-to-generator - Oxc implementation: https://github.com/oxc-project/oxc/blob/main/crates/oxc_transformer/src/es2017/async_to_generator.rs - Previous migrations: PR #11310, PR #11313 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>

74d487e

2 days ago

by github-actions[bot]

Home Terms Privacy Docs