fix/colab-pydantic-pickle - Branch - Eventual-Inc/Daft

fix: Fix Pydantic cloudpickle serialization in Google Colab

#5705

Comparing

fix/colab-pydantic-pickle

(

1e95fa6

) with

main

(

b15529d

)

Untouched: 24

Ignored: 4

Benchmarks

Passed

test_show[1 Small File]

tests/benchmarks/test_interactive_reads.py

+2%

12.2 ms12 ms

test_explain[100 Small Files]

tests/benchmarks/test_interactive_reads.py

+1%

12.1 ms11.9 ms

test_tpch_sql[1-in-memory-1]

tests/benchmarks/test_local_tpch.py

+1%

405.1 ms400.1 ms

test_tpch[1-in-memory-1]

tests/benchmarks/test_local_tpch.py

+1%

407.6 ms404.1 ms

test_tpch_sql[1-in-memory-10]

tests/benchmarks/test_local_tpch.py

+1%

190.9 ms189.6 ms

test_count[100 Small Files]

tests/benchmarks/test_interactive_reads.py

+1%

57.4 ms57.1 ms

test_iter_rows_first_row[1 Small File]

tests/benchmarks/test_interactive_reads.py

35.4 ms35.2 ms

test_tpch[1-in-memory-6]

tests/benchmarks/test_local_tpch.py

28.6 ms28.5 ms

test_tpch_sql[1-in-memory-8]

tests/benchmarks/test_local_tpch.py

134.8 ms134.4 ms

test_tpch_sql[1-in-memory-3]

tests/benchmarks/test_local_tpch.py

116.9 ms116.6 ms

test_tpch[1-in-memory-2]

tests/benchmarks/test_local_tpch.py

56.8 ms56.7 ms

test_tpch[1-in-memory-3]

tests/benchmarks/test_local_tpch.py

124.1 ms124 ms

test_tpch_sql[1-in-memory-5]

tests/benchmarks/test_local_tpch.py

117.5 ms117.5 ms

test_tpch[1-in-memory-7]

tests/benchmarks/test_local_tpch.py

125.9 ms126 ms

test_tpch_sql[1-in-memory-6]

tests/benchmarks/test_local_tpch.py

29.2 ms29.2 ms

test_tpch[1-in-memory-5]

tests/benchmarks/test_local_tpch.py

130.1 ms130.2 ms

test_tpch[1-in-memory-8]

tests/benchmarks/test_local_tpch.py

147.6 ms147.8 ms

test_tpch[1-in-memory-4]

tests/benchmarks/test_local_tpch.py

-1%

88 ms88.5 ms

test_tpch[1-in-memory-9]

tests/benchmarks/test_local_tpch.py

-1%

272.7 ms274.6 ms

test_tpch_sql[1-in-memory-7]

tests/benchmarks/test_local_tpch.py

-1%

118.1 ms119 ms

test_tpch_sql[1-in-memory-9]

tests/benchmarks/test_local_tpch.py

-1%

265.2 ms267.9 ms

test_tpch_sql[1-in-memory-4]

tests/benchmarks/test_local_tpch.py

-2%

88.8 ms90.5 ms

test_tpch[1-in-memory-10]

tests/benchmarks/test_local_tpch.py

-2%

195.4 ms199.5 ms

test_tpch_sql[1-in-memory-2]

tests/benchmarks/test_local_tpch.py

-2%

161 ms164.6 ms

Ignored

test_explain[1 Small File]

tests/benchmarks/test_interactive_reads.py

Ignored

+3%

2.1 ms2 ms

test_show[100 Small Files]

tests/benchmarks/test_interactive_reads.py

Ignored

-2%

30.9 ms31.6 ms

test_count[1 Small File]

tests/benchmarks/test_interactive_reads.py

Ignored

-4%

3.5 ms3.6 ms

test_iter_rows_first_row[100 Small Files]

tests/benchmarks/test_interactive_reads.py

Ignored

+13%

183.8 ms163 ms

Commits

Click on a commit to change the comparison range

Base

main

b15529d

-0.35%

fix: Handle UnionType in Pydantic model cleaning The `X | Y` union syntax (types.UnionType) is not subscriptable, so we need to use typing.Union to reconstruct union types when cleaning Pydantic models. Also adds test cases for: - Forward references (Parent with list[Child]) - Self-referential models (TreeNode with list[TreeNode] | None)

d67b618

5 days ago

by ykdojo

+0.38%

refactor: Extract Colab compatibility utils to separate module

5e2b798

5 days ago

by ykdojo

+0.21%

Merge branch 'main' into fix/colab-pydantic-pickle

f442168

2 days ago

by ykdojo

-0.29%

chore: remove colab test script (now linked in PR description)

19de566

2 days ago

by ykdojo

+0.1%

test: verify cleaned model has clean namespace

babc914

2 days ago

by ykdojo

-0.07%

Fix infinite recursion in clean_pydantic_model for self-referential models Skip self-references when collecting referenced models to prevent infinite recursion. Models like SingleChildTree with 'child: SingleChildTree | None' now clean correctly without RecursionError.

713c733

2 days ago

by ykdojo

+0.12%

Merge branch 'main' into fix/colab-pydantic-pickle

f8b24bb

9 hours ago

by ykdojo

-0.17%

Merge branch 'main' into fix/colab-pydantic-pickle

1e95fa6

5 hours ago

by ykdojo

Home Terms Privacy Docs